Skip to content

Handle CNV dataframes without coordinates#81

Draft
Mirochill wants to merge 1 commit into
castelao:mainfrom
Mirochill:fix-76-optional-coordinates
Draft

Handle CNV dataframes without coordinates#81
Mirochill wants to merge 1 commit into
castelao:mainfrom
Mirochill:fix-76-optional-coordinates

Conversation

@Mirochill

Copy link
Copy Markdown

Summary:

  • only add LATITUDE/LONGITUDE columns in as_DataFrame() when the CNV header has those attributes
  • add a regression covering a CNV payload without coordinates

Validation:

  • git diff --check HEAD~1..HEAD
  • static search for the coordinate guard and regression
  • Tests not run locally

Fixes #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encapsulate LAT/LON in try/except

1 participant