Add Python 3.11-3.13 support, drop 3.6-3.8 support - #78
Open
VeckoTheGecko wants to merge 5 commits into
Open
Conversation
Python 3.6-3.8 have reached end of life. * Remove dependency on deprecated pkg_resources * Update test matrix * add __init__.py to `rules` so its seen as a module and can be loaded in
VeckoTheGecko
marked this pull request as ready for review
September 26, 2024 16:45
Author
|
While adding 3.12/3.13 support it would be good to also patch one (or perhaps more, I only found 1) invalid escape sequences. e.g., |
\s would be an invalid escape character
Author
|
@castelao would you be able to run CI and review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This package is one of our dependencies and I saw it could do with a bit of a refresh to bring up to speed with modern Python.
Changes:
pkg_resourcesis deprecated in favour ofimportlib.resourceswhich was introduced in python 3.7. These changes useimportlib.resources.fileswhich was added in Python 3.9rulesso its seen as a moduleCleanup:
pyproject.toml).travis.yml(this looked legacy from what I could tell)requirements.txt(this information is already covered bypyproject.toml).\s)Python 3.13 is being released next week (1 Oct) so I think let's wait until then before merging and doing a minor release!