fix: await ledger.melt() call in test_melt_quote_reuse_same_outputs#1080
Open
vicjuma wants to merge 1 commit into
Open
fix: await ledger.melt() call in test_melt_quote_reuse_same_outputs#1080vicjuma wants to merge 1 commit into
vicjuma wants to merge 1 commit into
Conversation
The melt() call was wrapped in a trailing-comma tuple, which created the coroutine but never awaited it. This caused the first melt to be a silent no-op, meaning the test wasn't actually exercising the output-reuse scenario it claims to test. Fixes: coroutine 'Ledger.melt' was never awaited (RuntimeWarning)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
- Coverage 74.54% 74.52% -0.02%
==========================================
Files 115 115
Lines 13195 13195
==========================================
- Hits 9836 9834 -2
- Misses 3359 3361 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The melt() call was wrapped in a trailing-comma tuple, which created the coroutine but never awaited it. This led to a silent no-op, meaning the test wasn't actually exercising the output-reuse scenario it claims to test.
Fixes: coroutine 'Ledger.melt' was never awaited (RuntimeWarning)
Change:
Testing: