Skip to content

NUT-17: Simplify NUT-17 subscription kinds#372

Closed
callebtc wants to merge 1 commit into
mainfrom
nut-17-simplify-subscription-kind
Closed

NUT-17: Simplify NUT-17 subscription kinds#372
callebtc wants to merge 1 commit into
mainfrom
nut-17-simplify-subscription-kind

Conversation

@callebtc

@callebtc callebtc commented May 21, 2026

Copy link
Copy Markdown
Contributor

Implementations

Summary

  • replace method-specific SubscriptionKind values with generic mint_quote and melt_quote
  • keep proof_state unchanged
  • update NUT-17 command examples to advertise quote subscriptions per method-unit pair

Rationale

The subscription kind is now independent of the payment method, which makes the websocket API extensible to custom payment methods without needing method-specific quote kinds in the enum.

@Egge21M

Egge21M commented May 21, 2026

Copy link
Copy Markdown
Contributor

I like it. However we should make sure that mints are fine with signaling support only on that high level instead of on a method level

@robwoodgate robwoodgate left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. LGTM

@robwoodgate

robwoodgate commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

If we decide not to go this route for any reason, then we need to add online_mint_quote / online_melt_quote to the list, and remember to update it when new first class methods are added.

But with the companion PR below, this should allow mints and wallets to track existing and custom method quotes via websockets in a sane way:

@callebtc callebtc changed the title Simplify NUT-17 subscription kinds NUT-17: Simplify NUT-17 subscription kinds Jul 4, 2026
@callebtc callebtc closed this Jul 4, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in nuts Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants