NUT-17: Simplify NUT-17 subscription kinds#372
Closed
callebtc wants to merge 1 commit into
Closed
Conversation
This was referenced May 21, 2026
Contributor
|
I like it. However we should make sure that mints are fine with signaling support only on that high level instead of on a method level |
a1denvalu3
approved these changes
Jun 8, 2026
Collaborator
|
If we decide not to go this route for any reason, then we need to add But with the companion PR below, this should allow mints and wallets to track existing and custom method quotes via websockets in a sane way: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementations
Summary
SubscriptionKindvalues with genericmint_quoteandmelt_quoteproof_stateunchangedRationale
The subscription kind is now independent of the payment method, which makes the websocket API extensible to custom payment methods without needing method-specific quote kinds in the enum.