-
Notifications
You must be signed in to change notification settings - Fork 82
Deterministic pay to public key generation #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lescuer97
wants to merge
4
commits into
cashubtc:main
Choose a base branch
from
lescuer97:p2pk_recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,6 +39,18 @@ The HMAC-SHA256 KDF is built as the following: | |||||||
| 2. `hmac_digest = HMAC_SHA256(seed, message)`, where `HMAC_SHA256` is the [hash-based message authentication code](https://en.wikipedia.org/wiki/HMAC) using SHA-256 as the hashing algorithm. | ||||||||
| 3. `secret = hmac_digest` and `blinding_factor = hmac_digest % N`. | ||||||||
|
|
||||||||
| #### P2PK Derivation | ||||||||
|
|
||||||||
| Wallets are able to generate private keys in a deterministic way to have proofs locked to them. | ||||||||
|
|
||||||||
| The following BIP32 derivation path for derivation of the key: `m/129373'/10'/0'/0'/{counter}`: | ||||||||
|
|
||||||||
| - 129373': Purpose picked for P2PK derivation. | ||||||||
| - 10': Account for generating private keys for usage in P2PK. | ||||||||
| - {counter}: Incrementing counter encoded as an unsigned 64-bit integer in big-endian format. | ||||||||
|
thesimplekid marked this conversation as resolved.
|
||||||||
|
|
||||||||
| This will allow wallets to swap proof that are still locked to a public key during a restore process. | ||||||||
|
|
||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| ### Code Examples | ||||||||
|
|
||||||||
| #### Versioned Secret Derivation | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.