Use swiftlang SwiftSyntax repository#320
Open
afollestad wants to merge 1 commit into
Open
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
gilgtm
approved these changes
May 27, 2026
gilgtm
left a comment
There was a problem hiding this comment.
🤖 Approved after deep-dual review; no findings.
Author
Author
|
Also, it looks like Rulesets in this repo might need to be updated to match the correct versions for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
SwiftSyntax moved from the apple GitHub organization to the swiftlang organization. Downstream package graphs can now include both URLs when one dependency still references apple/swift-syntax.git and another references swiftlang/swift-syntax. SwiftPM normalizes both to the same package identity, swift-syntax, which produces duplicate identity warnings and extra repository update work during package resolution.
Using the canonical swiftlang/swift-syntax URL keeps Knit aligned with the current upstream repository location and avoids contributing the legacy URL to downstream dependency graphs.
Validation