Skip to content

Use swiftlang SwiftSyntax repository#320

Open
afollestad wants to merge 1 commit into
cashapp:mainfrom
afollestad:af/use-swiftlang-swift-syntax
Open

Use swiftlang SwiftSyntax repository#320
afollestad wants to merge 1 commit into
cashapp:mainfrom
afollestad:af/use-swiftlang-swift-syntax

Conversation

@afollestad
Copy link
Copy Markdown

@afollestad afollestad commented May 26, 2026

Summary

  • switch SwiftSyntax dependency URL from apple/swift-syntax.git to swiftlang/swift-syntax
  • update tracked Package.resolved files to match the canonical repository URL

Why?

SwiftSyntax moved from the apple GitHub organization to the swiftlang organization. Downstream package graphs can now include both URLs when one dependency still references apple/swift-syntax.git and another references swiftlang/swift-syntax. SwiftPM normalizes both to the same package identity, swift-syntax, which produces duplicate identity warnings and extra repository update work during package resolution.

Using the canonical swiftlang/swift-syntax URL keeps Knit aligned with the current upstream repository location and avoids contributing the legacy URL to downstream dependency graphs.

Validation

  • swift package resolve
  • swift build -v
  • swift test

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown

@gilgtm gilgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Approved after deep-dual review; no findings.

@afollestad
Copy link
Copy Markdown
Author

CC @luispadron @efirestone

@afollestad
Copy link
Copy Markdown
Author

Also, it looks like Rulesets in this repo might need to be updated to match the correct versions for build-knit-swift?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants