#882 full exp#884
Open
henrydingliu wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 87.04% 87.05%
=======================================
Files 86 86
Lines 4986 4989 +3
Branches 646 647 +1
=======================================
+ Hits 4340 4343 +3
Misses 456 456
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
allows a predicted triangle (e.g.
cl.Chainladder().fit_predict(tri)to call thefull_expectation_propertyRelated GitHub Issue(s)
closes #882
Additional Context for Reviewers
mirrors the logic from
full_triangle_uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Small property logic aligned with existing
full_triangle_behavior plus test tightening; no auth, security, or external API surface beyond actuarial helpers.Overview
full_expectation_now picks the cumulative vs incremental flag the same way asfull_triangle_: useX_.is_cumulativewhen a fittedX_exists, otherwiseself.is_cumulative. That letsfit_predictoutputs (e.g.cl.Chainladder().fit_predict(tri)) exposefull_expectation_without relying on a missing or wrongX_attribute.Tests add
fit_predictvsfitfull_expectation_checks withnp.allclose, and replace hard-coded0.00001tolerances with the sharedatolfixture.Reviewed by Cursor Bugbot for commit 91c528d. Bugbot is set up for automated code reviews on this repo. Configure here.