Skip to content

#869 friedland auto bi insurer premium#870

Open
kennethshsu wants to merge 8 commits into
mainfrom
#869_-friedland_auto_bi_insurer_premium
Open

#869 friedland auto bi insurer premium#870
kennethshsu wants to merge 8 commits into
mainfrom
#869_-friedland_auto_bi_insurer_premium

Conversation

@kennethshsu
Copy link
Copy Markdown
Collaborator

@kennethshsu kennethshsu commented May 28, 2026

Summary of Changes

Added premium to the friedland_auto_bi_insurer data

Related GitHub Issue(s)

Fixed #869

Additional Context for Reviewers

None

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Sample data and loader metadata only; no actuarial core or auth changes.

Overview
Adds Earned Premium to the Friedland friedland_auto_bi_insurer sample CSV (constant per accident year) and wires load_sample so auto_bi_insurer uses the same triangle columns as uspp: Paid Claims, Reported Claims, and Earned Premium.

Also includes a small cleanup in date_delta_adjustment (single-line timedelta assignment, trailing newline) and routine uv.lock updates (Python 3.14 resolution markers, additional greenlet wheel entries).

Reviewed by Cursor Bugbot for commit 78c218e. Bugbot is set up for automated code reviews on this repo. Configure here.

@kennethshsu kennethshsu self-assigned this May 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.04%. Comparing base (449b5c1) to head (78c218e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          86       86           
  Lines        4986     4986           
  Branches      646      646           
=======================================
  Hits         4340     4340           
  Misses        456      456           
  Partials      190      190           
Flag Coverage Δ
unittests 87.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kennethshsu kennethshsu marked this pull request as ready for review May 28, 2026 04:22
Comment thread chainladder/utils/utility_functions.py Outdated
]
origin: str = "Accident Half-Year"
development: str = "Calendar Half-Year"
if "auto_bi_insurer" in key.lower():
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance you could just piggyback off the next if statement?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, sounds good, and I just checked that uspp actually has the same order instead of what was listed.

@kennethshsu kennethshsu marked this pull request as draft May 28, 2026 21:35
Co-authored-by: Cursor <cursoragent@cursor.com>
@kennethshsu kennethshsu force-pushed the #869_-friedland_auto_bi_insurer_premium branch from 5a64bf4 to 50bca3e Compare May 28, 2026 21:39
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 03cf351. Configure here.

Comment thread chainladder/utils/utility_functions.py Outdated
@kennethshsu kennethshsu marked this pull request as ready for review May 28, 2026 22:00
@henrydingliu
Copy link
Copy Markdown
Collaborator

@genedan I'm not sure if this reverted back any of your recent refactors. Could you please provide the review?

@kennethshsu
Copy link
Copy Markdown
Collaborator Author

@genedan I'm not sure if this reverted back any of your recent refactors. Could you please provide the review?

Ya I have no idea where I pulled that code from, probably accidentally from the wrong branch. But based on reviewing only the diffs I think it's clean.

@henrydingliu
Copy link
Copy Markdown
Collaborator

@kennethshsu i just realized i made a doodoo. the latest load_sample clean-up from #886 deprecates some of the pattern here. should've sequenced these better. i will open a new PR for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

friedland_auto_bi_insurer missing premium

2 participants