#869 friedland auto bi insurer premium#870
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 86 86
Lines 4986 4986
Branches 646 646
=======================================
Hits 4340 4340
Misses 456 456
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ] | ||
| origin: str = "Accident Half-Year" | ||
| development: str = "Calendar Half-Year" | ||
| if "auto_bi_insurer" in key.lower(): |
There was a problem hiding this comment.
any chance you could just piggyback off the next if statement?
There was a problem hiding this comment.
Ya, sounds good, and I just checked that uspp actually has the same order instead of what was listed.
Co-authored-by: Cursor <cursoragent@cursor.com>
5a64bf4 to
50bca3e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 03cf351. Configure here.
|
@genedan I'm not sure if this reverted back any of your recent refactors. Could you please provide the review? |
Ya I have no idea where I pulled that code from, probably accidentally from the wrong branch. But based on reviewing only the diffs I think it's clean. |
|
@kennethshsu i just realized i made a doodoo. the latest load_sample clean-up from #886 deprecates some of the pattern here. should've sequenced these better. i will open a new PR for your review. |

Summary of Changes
Added premium to the friedland_auto_bi_insurer data
Related GitHub Issue(s)
Fixed #869
Additional Context for Reviewers
None
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Sample data and loader metadata only; no actuarial core or auth changes.
Overview
Adds Earned Premium to the Friedland
friedland_auto_bi_insurersample CSV (constant per accident year) and wiresload_samplesoauto_bi_insureruses the same triangle columns asuspp: Paid Claims, Reported Claims, and Earned Premium.Also includes a small cleanup in
date_delta_adjustment(single-line timedelta assignment, trailing newline) and routineuv.lockupdates (Python 3.14 resolution markers, additionalgreenletwheel entries).Reviewed by Cursor Bugbot for commit 78c218e. Bugbot is set up for automated code reviews on this repo. Configure here.