Render accordion aria-expanded as "true"/"false" strings (CS-12256)#5553
Merged
burieberry merged 1 commit intoJul 21, 2026
Merged
Conversation
Binding a raw boolean stamps an empty-valued attribute when open and removes it when closed — both invalid for the enumerated aria-expanded attribute. The chevron-rotation selector keyed off attribute presence, so it moves to [aria-expanded='true'] now that the attribute is always present. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
jurgenwerk
approved these changes
Jul 21, 2026
burieberry
deleted the
cs-12256-accordionitem-renders-aria-expanded-as-an-empty-attribute
branch
July 21, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created as a result of a failing issue-tracker live card test.
Background
The
AccordionItemtrigger boundaria-expandedto a raw boolean, which Glimmer renders as an empty-valued attribute when open and removes entirely when closed. Both states are invalid foraria-expanded, an enumerated attribute whose meaningful values are the strings"true"and"false"— and the attribute should stay present on a toggle so assistive technology announces the collapsed state. Every Accordion in the app was affected.Changes
aria-expanded={{if @isOpen 'true' 'false'}}, matching how the content region already handlesaria-hidden.[aria-expanded]), which only worked because of the presence-only-when-open bug; it now targets[aria-expanded='true']."true"/"false"contract plus thedata-state/aria-hiddensignals on the content region, so a regression here fails loudly instead of silently.Testing
Full boxel-ui test-app suite passes (394/394) including the new accordion test.
🤖 Generated with Claude Code