Add pr-review skill codifying the inline-first PR review method#5538
Merged
Conversation
Distills the review style from recent well-received reviews into a repeatable skill: context-first investigation, empirically verified claims, classified findings (regression / pre-existing / follow-up / confirmation), inline-first comment placement, and the standing privacy / evergreen / attribution checks applied in both directions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52cd20298b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The posting flow the skill mandates names these MCP tools directly; listing them in allowed-tools lets the submit step run without a mid-flow permission prompt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Claude skill, pr-review, intended to standardize how pull request reviews are performed and written (inline-first, evidence-backed, and evergreen).
Changes:
- Add
.claude/skills/pr-review/SKILL.mddefining the PR review workflow and comment-writing rubric.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukemelia
approved these changes
Jul 17, 2026
Re-reviews diff since the last reviewed commit, verify each fix as a change rather than as compliance, land critique as threaded replies in the thread the author responded to, and skip background a thread already carries. Also clarify that the code-review pointer refers to the Claude Code built-in, and spell the submit tool name in full. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Allowlists the read-only lint/typecheck, CI-artifact, Linear-read, and screenshot tool calls Claude uses most in this repo, so review and diagnostic flows run autonomously instead of pausing on permission prompts. The aws entry is bounded server-side by the read-only IAM role its profile assumes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our GitHub Copilot plan with unlimited PR reviews is ending, so automated review coverage moves to Claude. For that to work as a real replacement, reviews need to be consistent in shape and quality no matter who invokes them — which means the method has to live in a skill rather than in any one person's practice.
This adds a
pr-reviewskill that encodes the review method:This also pre-approves the most common read-only tool calls (lint/typecheck runs, CI-artifact downloads, Linear reads, screenshots) in the project Claude settings, so reviews and other Claude flows run autonomously instead of pausing on permission prompts for read-only work. The
awsentry is bounded server-side by the read-only IAM role its profile assumes.Documentation and settings only; no runtime surface.
🤖 Generated with Claude Code