Skip to content

Make block card/file embed refs use the legible inline highlight #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FadhlanR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make block card/file embed refs use the legible inline highlight #5532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/base/codemirror-editor.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1602,17 +1602,6 @@ export default class CodeMirrorEditor extends GlimmerComponent<CodeMirrorEditorS
color: var(--boxel-400, #666);
}

.codemirror-editor :deep(.cm-bfm-card-ref--block) {
display: inline-block;
font-size: 0.85em;
color: var(--boxel-400, #666);
padding: 2px 6px;
}

.codemirror-editor :deep(.cm-bfm-card-ref--active) {
background-color: var(--boxel-highlight-hover, #e8f0fe);
}

/* ── Card widget containers ── */
.codemirror-editor :deep(.cm-card-widget) {
user-select: none;
Expand Down
6 changes: 2 additions & 4 deletions packages/host/app/lib/codemirror-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,7 @@ function buildCardDecorations(
from,
to,
value: Decoration.mark({
class:
'cm-bfm-card-ref cm-bfm-card-ref--block cm-bfm-card-ref--active',
class: 'cm-bfm-card-ref cm-bfm-card-ref--inline',
}),
});
} else if (onCursor) {
Expand All @@ -682,8 +681,7 @@ function buildCardDecorations(
from,
to,
value: Decoration.mark({
class:
'cm-bfm-card-ref cm-bfm-card-ref--block cm-bfm-card-ref--active',
class: 'cm-bfm-card-ref cm-bfm-card-ref--inline',
}),
});
let previewWidget = new CardWidget(cardId, 'block', refType);
Expand Down
Loading