-
Notifications
You must be signed in to change notification settings - Fork 12
Change the host store to allow prefix RRI keys #5470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
backspace
wants to merge
16
commits into
main
Choose a base branch
from
cs-11730-s3-canonical-store-key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−11
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1fca86d
refactor: key the host store by canonical identifier spelling
backspace d95b506
fix: keep the render store's load path in resolved-URL form
backspace 061552d
fix: resolve prefix-form ids in realmOf so realm subscriptions install
backspace 0000c78
fix: compare realm membership in URL space when unsubscribing
backspace 7b1ab21
perf: use memoized toURLHref for store id resolution
backspace 8aef362
perf: use memoized toURLHref in render-service id normalization
backspace b619927
test: assert prefix-form reference unsubscribes on last drop
backspace b281d34
Revert unsubscribe realm-membership fix and its test
backspace d873935
Decouple realm subscription lifetime from instance reference counts
backspace a9c808e
Only release realm subscriptions on destroy, not resetState
backspace 8b321c8
Update file-meta subscription test to the not-reference-counted contract
backspace af2a2a8
Merge remote-tracking branch 'origin/main' into cs-11730-s3-canonical…
backspace bf2c87a
Merge remote-tracking branch 'origin/main' into cs-11730-s3-canonical…
backspace e26b2c8
Drop the realm-subscription lifetime rework; keep §3 keying only
backspace df29628
Revert toURLHref keying back to toURL(id).href
backspace c553362
Merge remote-tracking branch 'origin/main' into cs-11730-s3-canonical…
backspace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.