Sweep remaining command-naming residue in tests, selectors, and locals (CS-12042)#5465
Merged
Conversation
Contributor
Preview deploymentsHost Test Results 1 files ±0 1 suites ±0 2h 58m 10s ⏱️ + 2m 59s Results for commit e910bd0. ± Comparison against earlier commit 59a7ff8. Realm Server Test Results 1 files ±0 1 suites ±0 10m 53s ⏱️ -24s Results for commit e910bd0. ± Comparison against earlier commit 59a7ff8. |
lukemelia
force-pushed
the
rename-command-residue-sweep
branch
from
July 10, 2026 04:49
d0e5f37 to
22cce6b
Compare
jurgenwerk
approved these changes
Jul 10, 2026
lukemelia
changed the base branch from
cs-12041-rename-ai-bot-prompt-assembly-sweep
to
main
July 10, 2026 12:07
Test surfaces move to tool naming: tests/integration/tools/ (dir + the
command-named files inside), acceptance/tools-test.gts, the
ai-assistant-panel tools-test, the matrix tools spec, and the module
titles in each. Component CSS classes (tool-description,
tool-result-card-*, the tool-field embedded styles) and the remaining
host identifier residue (toolToRun, instantiateToolInput, messageTool,
skillTool, the drain-queue members, isAutoExecutableTool, ...) follow.
Restores the catalog test-card getService('tool-service') fix that was
lost from the CS-12040 lineage during a rebase — runtime was unaffected
(the command-service alias initializer resolves the old key) but the
catalog typecheck was red.
The command-runner route's data-command-result output attribute is
deliberately untouched: the route is an external URL contract and the
attribute is part of its consumed DOM surface.
Part of the command -> tool rename close-out (CS-12042 / CS-11788).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The three content-facing surfaces each gain toolContext, with the old name kept as a deprecated reader of the same value: - Tool base class: `this.toolContext` is the property; a protected commandContext getter serves realm-content tool classes that read the pre-rename spelling in run(). - tool-service: `toolContext` getter is primary; commandContext aliases it for content that constructs tools via the service (reached through either service-registration key). - CardContext: cards read `@context.toolContext`; commandContext is declared and populated with the same value wherever the host builds a CardContext, for content still reading the old key. All in-repo consumers move to toolContext. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lukemelia
force-pushed
the
rename-command-residue-sweep
branch
from
July 10, 2026 12:11
22cce6b to
59a7ff8
Compare
The shorter module title fits prettier's unwrapped form. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The final in-repo residue sweep for the command → tool rename (CS-11788), stacked on #5462. A repo audit after the four rename slices found ~2500 remaining case-insensitive "command" hits; roughly 60% are deliberate keepers (wire format, compat aliases, external contracts, other-domain uses like yargs/VS Code commands) and this PR eliminates the other ~40%:
tests/integration/commands/→tools/(plus the command-named files inside),acceptance/tools-test.gts, the ai-assistant-paneltools-test, the matrixtools.spec.ts, and the module titles in each (Acceptance | Tools tests,Integration | tools | …).command-description,command-result-card-*, and the tool-field embedded styles become tool-named, with the test selectors that query them updated in lockstep.toolToRun,instantiateToolInput,messageTool/skillToollocals, the drain-queue members,isAutoExecutableTool, and friends.Also restores a lost fix
The catalog test cards'
getService('tool-service')change from CS-12040 was lost from that branch's lineage during a rebase and #5458 merged without it. Runtime was unaffected — thecommand-servicealias initializer resolves the old key, which is exactly the compat path working as designed — but the catalog typecheck was red (it isn't in CI). Re-applied here.Deliberately untouched (the keepers, dispositioned)
boxel-cli yargs commands; VS Code's
vscode.commandsAPI; bot-runner'scommand-runner-route protocol including the route path and itsdata-command-resultoutput attribute (external URL/DOM contract for Grafana operator actions);commandModule/loadCommandModule(named for the deferredbase/commandmodule);commandContext(public content API);commandRequestIdand theLEGACY_*wire constants; the base realm's retainedSkill.commandscard field and all compat alias exports; hash-stability tests that pin the legacy mapping.Verification
Host/runtime-common/ai-bot/catalog type-checks clean; host lint + template-lint clean; ai-bot 224/226 (standing local env failures); the renamed
Acceptance | Tools testsmodule verified in the browser harness (16 tests, 64/64 assertions).🤖 Generated with Claude Code