refactor: Change static imports to use @cardstack/base#5452
Merged
Conversation
Contributor
Preview deploymentsHost Test Results 1 files ± 0 1 suites ±0 2h 48m 23s ⏱️ + 2m 32s Results for commit 3a4b2ab. ± Comparison against earlier commit 8881bc1. Realm Server Test Results 1 files ±0 1 suites ±0 12m 26s ⏱️ + 1m 28s Results for commit 3a4b2ab. ± Comparison against earlier commit 8881bc1. |
backspace
changed the title
@cardstack/base@cardstack/base
backspace
marked this pull request as ready for review
July 9, 2026 17:23
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3f5f9f3a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
backspace
force-pushed
the
cs-10756-base-import-sweep
branch
from
July 9, 2026 17:47
f3f5f9f to
013a25f
Compare
backspace
added a commit
that referenced
this pull request
Jul 9, 2026
The conversion pass had also run prettier over every touched file, which reformatted regions unrelated to the import change — including markdown-format templates whose leading whitespace is part of the rendered output (a markdown-rendered card would gain indented/code-block content). Normalize every swept file to exactly the upstream content plus the specifier replacement; formatting stays as each file had it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
backspace
added a commit
that referenced
this pull request
Jul 9, 2026
The rebase over the CLI RRI support left two identical prefix-form expectations; make them one URL-form and one prefix-form so both spellings keep coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
backspace
changed the title
@cardstack/base@cardstack/base
backspace
added a commit
that referenced
this pull request
Jul 9, 2026
The conversion pass had also run prettier over every touched file, which reformatted regions unrelated to the import change — including markdown-format templates whose leading whitespace is part of the rendered output (a markdown-rendered card would gain indented/code-block content). Normalize every swept file to exactly the upstream content plus the specifier replacement; formatting stays as each file had it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
backspace
added a commit
that referenced
this pull request
Jul 9, 2026
The rebase over the CLI RRI support left two identical prefix-form expectations; make them one URL-form and one prefix-form so both spellings keep coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
backspace
force-pushed
the
cs-10756-base-import-sweep
branch
2 times, most recently
from
July 9, 2026 22:20
83788d3 to
8881bc1
Compare
habdelra
approved these changes
Jul 9, 2026
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Part of the sweep converting in-repo base-module imports from the https://cardstack.com/base/ URL form to the canonical @cardstack/base/ prefix: static and literal-dynamic specifiers, tsconfig paths carrying both spellings, and import ordering per the specifier's new sort group. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Same conversion for ai-bot, boxel-cli, matrix, bot-runner, openrouter-realm, vscode-boxel-tools, postgres, catalog, billing, and boxel-ui's tsconfig, plus the type-check configs that map the base package by specifier: boxel-cli's embedded parse tsconfig and software-factory's generated parse tsconfig. Test expectations that assert specifier spellings cover both forms. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
backspace
force-pushed
the
cs-10756-base-import-sweep
branch
from
July 9, 2026 23:27
8881bc1 to
3a4b2ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mechanical replacement of imports at the tops of files, and the same sorts of imports in test strings.