Change server-side query field searches to use RRIs (CS-11730)#5447
Merged
Conversation
The realm server's executeQueryForField resolved query-field type refs through its VirtualNetwork to URL form, so the links.search seed URLs it serializes into indexed documents spelled refs differently from the client's RRI-space rebuild of the same query. The index matches either spelling and the client compares seeds via the spelling-tolerant signature, so both spellings work — but building in RRI space converges the two sides (new seeds match the client query byte-for-byte) and removes the last normalizeQueryDefinition caller that supplied a VirtualNetwork. With no callers left, drop the param: query-field normalization is now VN-free. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
backspace
marked this pull request as ready for review
July 9, 2026 14:26
habdelra
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the server version of #5424.