fix: add epoch_no DESC sort to getLatestEpochInfo and getLatestEpochParameters#191
Open
skisel-bt wants to merge 1 commit into
Open
fix: add epoch_no DESC sort to getLatestEpochInfo and getLatestEpochParameters#191skisel-bt wants to merge 1 commit into
skisel-bt wants to merge 1 commit into
Conversation
…arameters Without explicit ordering, the Koios API may return a stale node's entry at position [0], causing these methods to return outdated epoch data. Fixes cardano-community#190 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #190
getLatestEpochInfo()andgetLatestEpochParameters()both fetch withLimit.of(1)but without explicit ordering. The Koios API does not guarantee result order, so behind a load balancer a stale node's entry can appear at[0], returning outdated epoch data.Adding
Order.by("epoch_no", SortType.DESC)ensures the first result is always the most recent epoch.Verified with curl —
?limit=1&order=epoch_no.descconsistently returns the correct latest epoch whereas?limit=1alone returns stale results intermittently.Test plan
getLatestEpochParameters()returns correct PlutusV3 cost model entries consistentlygetLatestEpochInfo()returns the latest epoch consistently🤖 Generated with Claude Code