feat: add onAuthError option for credential-expiry detection#75
Open
kcheng486 wants to merge 1 commit into
Open
feat: add onAuthError option for credential-expiry detection#75kcheng486 wants to merge 1 commit into
kcheng486 wants to merge 1 commit into
Conversation
Surface signed-request failures (HTTP 400/401) through a new optional onAuthError(status) layer option so consumers can detect expired credentials and refresh them. transformRequest is only used for signed/authenticated requests, so a 400 can be due to expired credentials(401 not authorized, missing -> 404, denied -> 403). Because temporary credentials in particular return 400 (ExpiredToken/ InvalidToken), often with no readable body (HEAD probes / CORS-gated errors), we have to rely on the status code itself. On 400/401 the fetch store calls onAuthError(status) and remaps to 404 so the read is treated as a missing chunk instead of throwing. The existing 403->404 remap is left untouched (no onAuthError) so sparse pyramids that 403 absent chunks don't trigger spurious refreshes.
|
@kcheng486 is attempting to deploy a commit to the carbonplan Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface signed-request failures (HTTP 400/401) through a new optional onAuthError(status) layer option so consumers can detect expired credentials and refresh them.
transformRequest is only used for signed/authenticated requests, so a 400 is due to expired credentials(not authorized -> 401, missing -> 404, denied -> 403). Because temporary credentials in particular return 400 (ExpiredToken/ InvalidToken), often with no readable body (HEAD probes / CORS-gated errors), we have to rely on the status code itself. On 400/401 the fetch store calls onAuthError(status) and remaps to 404 so the read is treated as a missing chunk instead of throwing. The existing 403->404 remap is left untouched (no onAuthError) so sparse pyramids that 403 absent chunks don't trigger spurious refreshes.