fix: let customFrag own NaN discard decisions#72
Open
Shane98c wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
In multi-band mode the generated fragment shader injected an any-band-NaN
discardbeforecustomFragran, so aggregations over partial coverage (e.g. multi-model median/mean with gaps) could only render the intersection of all bands, never the union.Now when a
customFragis supplied it owns the discard decision — every band value is already in scope (NaN included for missing/fill pixels), so the shader chooses how to handle missing bands. Default (no-customFrag) single- and multi-band paths keep their existing discards.Breaking: existing
customFragshaders that relied on the implicit NaN discard must now add their owndiscard. README examples updated to show the pattern.