Skip to content

refactor!: removing setup.cfg support and using uv sync for local package installation#152

Open
ak-gupta wants to merge 10 commits into
mainfrom
deprecate-cfg
Open

refactor!: removing setup.cfg support and using uv sync for local package installation#152
ak-gupta wants to merge 10 commits into
mainfrom
deprecate-cfg

Conversation

@ak-gupta

Copy link
Copy Markdown
Contributor

Description

In this PR, I have removed setup.cfg support in favour of pyproject.toml. Additionally, I am switching our local package installation from

uv pip install .

to

uv sync --inexact

with the additional arguments for extras, etc.

Finally, I have switched the order in which we call the pre-run hook and environment filtering. I'm doing this to allow for programmatically derived environments to be isolated at the command line.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ak-gupta

Copy link
Copy Markdown
Contributor Author

Windows tests are failing... I am wondering why we have formal windows support? Especially with WSL2?

@fdosani fdosani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants