-
Notifications
You must be signed in to change notification settings - Fork 13
chore: cds^10 #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
chore: cds^10 #440
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b131fff
no in-memory queue in cds^10
sjvans 8317c68
cds9
sjvans 421bb3b
fix copy paste error
sjvans 4aacf94
Merge branch 'main' into cds10
sjvans 65175b8
rm cds^8 from matrix
sjvans 4a9bf52
wait for E2
sjvans 3f2a0c7
rm in-memory-outbox test
sjvans 369061f
skip persistent-outbox test until switched to vitest
sjvans 9691311
add snapshot counters for test stability
sjvans dfd1e52
prep [10, 9]
sjvans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,4 +135,5 @@ dist | |
| # test | ||
| test/msg-box | ||
| test/bookshop/gen | ||
| test/bookshop/.cdsrc.json | ||
|
|
||
| .claude/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| { | ||
| "[logging]": { | ||
| "requires": { | ||
| "telemetry": { | ||
| "tracing": { | ||
| "sampler": { | ||
| "ignoreIncomingPaths": ["/odata/v4/admin/Genres"] | ||
| } | ||
| }, | ||
| "logging": { | ||
| "exporter": { | ||
| "module": "@opentelemetry/sdk-logs", | ||
| "class": "ConsoleLogRecordExporter" | ||
| }, | ||
| "processor": { | ||
| "module": "./lib/MySimpleLogRecordProcessor.js", | ||
| "class": "MySimpleLogRecordProcessor" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "log": { | ||
| "format": "json", | ||
| "cls_custom_fields": ["foo"] | ||
| } | ||
| }, | ||
| "[metrics]": { | ||
| "requires": { | ||
| "telemetry": { | ||
| "metrics": { | ||
| "config": { | ||
| "exportIntervalMillis": 100 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "[metrics-outbox]": { | ||
| "requires": { | ||
| "queue": true, | ||
| "telemetry": { | ||
| "metrics": { | ||
| "config": { | ||
| "exportIntervalMillis": 100 | ||
| }, | ||
| "_db_pool": false, | ||
| "_queue": true, | ||
| "exporter": { | ||
| "module": "@opentelemetry/sdk-metrics", | ||
| "class": "ConsoleMetricExporter" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "[metrics-outbox-disabled]": { | ||
| "requires": { | ||
| "queue": true, | ||
| "telemetry": { | ||
| "metrics": { | ||
| "config": { | ||
| "exportIntervalMillis": 250 | ||
| }, | ||
| "_db_pool": false, | ||
| "_queue": false, | ||
| "exporter": { | ||
| "module": "@opentelemetry/sdk-metrics", | ||
| "class": "ConsoleMetricExporter" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "[tracing-attributes]": { | ||
| "requires": { | ||
| "telemetry": { | ||
| "tracing": { | ||
| "exporter": { | ||
| "module": "@opentelemetry/sdk-trace-node" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "[persistent-outbox]": { | ||
| "requires": { | ||
| "messaging": { | ||
| "kind": "file-based-messaging", | ||
| "file": "../persistent-outbox" | ||
| } | ||
| } | ||
| }, | ||
| "[without-outbox]": { | ||
| "requires": { | ||
| "messaging": { | ||
| "kind": "file-based-messaging", | ||
| "file": "../without-outbox", | ||
| "outboxed": false | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 7 additions & 9 deletions
16
...-messaging-with-persistent-outbox.test.js → ...acing-messaging-persistent-outbox.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,20 @@ | ||
| const CASE = 'with_persistent-outbox' | ||
| const CASE = 'persistent-outbox' | ||
|
|
||
| const env = { | ||
| // REVISIT: even with profile "persistent-outbox", messaging kind and file from package.json wins | ||
| process.env.cds_requires_messaging = JSON.stringify({ | ||
| kind: 'file-based-messaging', | ||
| outbox: true, | ||
| file: `../${CASE}` | ||
| } | ||
| process.env.cds_requires_messaging = JSON.stringify(env) | ||
| process.env.cds_requires_outbox = JSON.stringify({ kind: 'persistent-outbox' }) | ||
|
|
||
| process.env.cds_requires_telemetry_metrics = null | ||
| }) | ||
|
|
||
| // REVISIT: check json exports | ||
| const CHECK = (log, expect) => { | ||
| // 3: outbox -> consumers get new root context | ||
| // REVISIT: for some reason, span "cds.spawn run task" has no parent when running in jest | ||
| expect(log.output.match(/\[telemetry\] - elapsed times:/g).length).to.equal(4) //> actually 3 | ||
| expect(log.output.match(/cds.spawn - schedule task/g).length).to.equal(1) | ||
| } | ||
|
|
||
| describe(`tracing messaging - ${CASE}`, () => { | ||
| // REVISIT: re-enable with switch to vitest | ||
| describe.skip(`tracing messaging - ${CASE}`, () => { | ||
| require('./tracing-messaging')(CASE, CHECK) | ||
| }) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic Error: The snapshot at line 182-183 is taken after
await wait(300)at line 176, meaning E2's retry has already been processed andtotalOut/totalFailedmay already reflect the extra increment from retry 2. The snapshot should be taken before the 300ms wait to reliably capture the state before the retry fires.Double-check suggestion before committing. Edit this comment for amendments.
Please provide feedback on the review comment by checking the appropriate box: