feat: optional axios tracing setup based on axios-debug-log presence#410
Open
kulliax wants to merge 2 commits into
Open
feat: optional axios tracing setup based on axios-debug-log presence#410kulliax wants to merge 2 commits into
kulliax wants to merge 2 commits into
Conversation
Contributor
|
hi @kulliax sorry for the late reply. we already wrap sap cloud sdk's executeHttpRequest and executeHttpRequestWithOrigin. why is that not sufficient when using pls? which version were you on? could #402 (in v1.6.0) have been the issue? |
Contributor
Author
|
Hi @sjvans, we will test this again as part of the migration to CAP 10. As described in the ticket linked above, the request is treated as a whole. However, for analysis purposes, we also need the sub-requests. |
Contributor
Author
|
currently we use @cap-js/telemetry@1.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft that we use for our PLS logging, see issue #397
Activation by adding the axios-debug-log module. I tried implementing the SAP Cloud SDK, but gave up after a while because this method works.
