test: adapt to cds 9#344
Conversation
| // 2: no outbox -> consumer gets new root context | ||
| // REVISIT: for some reason, the emit done in the on succeeded callback gets a new root context when running in jest | ||
| expect(log.output.match(/\[telemetry\] - elapsed times:/g).length).to.equal(3) //> actually 2 | ||
| expect(log.output.match(/\[telemetry\] - elapsed times:/g).length).to.equal(4) |
There was a problem hiding this comment.
log.output in cds 8:
log.outputin cds 9:
There was a problem hiding this comment.
i think we should deactivate the queue for the existing tests and then add extra ones for it
There was a problem hiding this comment.
Not sure if I understand your comment, sorry. Tests for outbox: false are already in place in test/tracing-messaging-without-outbox.test.js, or?
There was a problem hiding this comment.
right, but that worked because the persistent outbox was off by default, i.e., the disabling was omitted. now, we need to explicitly set the in memory outbox: https://github.com/cap-js/telemetry/pull/338/files#diff-08b958738e72f5b16d4eb669fe005de06cf9dfc430ecda1494064d1dec87c93bR5
| 'log.type': 'LogRecord', | ||
| 'exception.message': "Cannot read properties of undefined (reading 'exist')", | ||
| 'exception.stacktrace': s => s.match(/^TypeError: .+(\n\s+at .+){6}$/), | ||
| 'exception.stacktrace': s => s.match(/^TypeError: .+(\n\s+at .+){5}$/), |
There was a problem hiding this comment.
stacktrace got shorter...
|
superseded by #338 |
2 participants
No description provided.