fix(protocol-resolver): map CAP 'mcp' protocol to ORD apiProtocol#519
Merged
Conversation
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR is clean and well-structured. The core change — adding "mcp": ORD_API_PROTOCOL.MCP to CAP_TO_ORD_PROTOCOL_MAP — is correct and follows the exact same pattern used for GraphQL. The test refactoring in api-resource.test.js simplifies the MCP test by replacing the brittle jest.doMock/jest.resetModules approach with a proper beforeEach/afterEach protocol registration, which is a clear improvement. The only gap I flagged is a missing "silent skip without plugin" test case to match the symmetry with the GraphQL test suite.
PR Bot Information
Version: 1.27.6
- Correlation ID:
5290cc40-8056-11f1-8968-26e18ef9f158 - Agent Instructions:
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened
ord-e2e-bot
Bot
removed
the
retry-e2e
ord-e2e-bot
Bot
removed
the
retry-e2e
mlakov
approved these changes
Jul 15, 2026
ord-e2e-bot
Bot
removed
the
retry-e2e
ord-e2e-bot
Bot
removed
the
retry-e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.