Skip to content

Pass java-version to deploy-release action#862

Merged
Schmarvinius merged 1 commit into
mainfrom
fix/release-pass-java-version
Jul 17, 2026
Merged

Pass java-version to deploy-release action#862
Schmarvinius merged 1 commit into
mainfrom
fix/release-pass-java-version

Conversation

@Schmarvinius

Copy link
Copy Markdown
Contributor

The release pipeline currently fails at the Deploy step because the upstream cap-java/.github/actions/deploy-release used to hardcode JDK 17, while this project builds on JDK 21.

With cap-java/.github#16 merged, this passes java-version: ${{ env.JAVA_VERSION }} (21) to the deploy action so mvn clean deploy recompiles under the correct JDK.

Depends on cap-java/.github#16.

@Schmarvinius
Schmarvinius requested a review from a team as a code owner July 17, 2026 08:34
@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Pass java-version to Deploy-Release Action

Bug Fix

🐛 Fixed a release pipeline failure at the Deploy step caused by a JDK version mismatch. The upstream cap-java/.github/actions/deploy-release action previously hardcoded JDK 17, while this project builds on JDK 21. This change passes java-version: ${{ env.JAVA_VERSION }} (21) explicitly to the deploy action, ensuring mvn clean deploy compiles under the correct JDK.

Changes

  • .github/workflows/release.yml: Added java-version: ${{ env.JAVA_VERSION }} input to the Deploy step that calls cap-java/.github/actions/deploy-release@main, aligning the deploy JDK with the project's configured Java version.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.28.0

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is straightforward and correct. The java-version: ${{ env.JAVA_VERSION }} parameter is added to the deploy-release action call, consistent with how other steps in the workflow (e.g., build at line 98, verify-version at line 38) already pass the same env variable. The JAVA_VERSION env var is defined at the top of the file as '21', which matches the project's requirement (CLAUDE.md: "Java 17+ and Maven 3.6.3+ required", and the workflow defines JAVA_VERSION: '21').

No issues found — the change is minimal, correct, and consistent with the existing workflow patterns.

The PR makes a small, well-targeted fix: adding the missing java-version parameter to the deploy-release action so it uses JDK 21 (consistent with the rest of the workflow), resolving the deployment failure described in the PR description.

PR Bot Information

Version: 1.28.0

  • Event Trigger: pull_request.opened
  • Correlation ID: 491948d0-81ba-11f1-8658-32d6982981e3
  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Agent Instructions:

@Schmarvinius
Schmarvinius merged commit 820452e into main Jul 17, 2026
20 checks passed
@Schmarvinius
Schmarvinius deleted the fix/release-pass-java-version branch July 17, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants