Pass java-version to deploy-release action#862
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Pass
|
There was a problem hiding this comment.
The change is straightforward and correct. The java-version: ${{ env.JAVA_VERSION }} parameter is added to the deploy-release action call, consistent with how other steps in the workflow (e.g., build at line 98, verify-version at line 38) already pass the same env variable. The JAVA_VERSION env var is defined at the top of the file as '21', which matches the project's requirement (CLAUDE.md: "Java 17+ and Maven 3.6.3+ required", and the workflow defines JAVA_VERSION: '21').
No issues found — the change is minimal, correct, and consistent with the existing workflow patterns.
The PR makes a small, well-targeted fix: adding the missing java-version parameter to the deploy-release action so it uses JDK 21 (consistent with the rest of the workflow), resolving the deployment failure described in the PR description.
PR Bot Information
Version: 1.28.0
- Event Trigger:
pull_request.opened - Correlation ID:
491948d0-81ba-11f1-8658-32d6982981e3 - File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet - Agent Instructions:
The release pipeline currently fails at the Deploy step because the upstream
cap-java/.github/actions/deploy-releaseused to hardcode JDK 17, while this project builds on JDK 21.With cap-java/.github#16 merged, this passes
java-version: ${{ env.JAVA_VERSION }}(21) to the deploy action somvn clean deployrecompiles under the correct JDK.Depends on cap-java/.github#16.