Skip to content

refactor: accept SDK API clients as constructor parameters #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Schmarvinius merged 7 commits into from
May 28, 2026
Merged

refactor: accept SDK API clients as constructor parameters #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e217a96
fix: use idiomatic patterns for error messages and stream collection
Schmarvinius May 27, 2026
c995305
refactor: use cds-maven-plugin generated interfaces for type-safe ent…
Schmarvinius May 27, 2026
cf971b4
refactor: slim AICoreService interface to public API surface
Schmarvinius May 27, 2026
7cf0ce9
refactor: decompose FioriRecommendationHandler into focused helpers
Schmarvinius May 27, 2026
5c71d85
refactor: accept SDK API clients as constructor parameters
Schmarvinius May 27, 2026
5280a93
Merge remote-tracking branch 'origin/main' into fix/36-api-client-inj…
Schmarvinius May 28, 2026
1f2a424
refactor: remove convenience constructor, pass API clients explicitly
Schmarvinius May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...ure-ai-core/src/main/java/com/sap/cds/feature/aicore/core/AICoreServiceConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
*/
package com.sap.cds.feature.aicore.core;

import com.sap.ai.sdk.core.AiCoreService;
import com.sap.ai.sdk.core.client.ConfigurationApi;
import com.sap.ai.sdk.core.client.DeploymentApi;
import com.sap.ai.sdk.core.client.ResourceGroupApi;
import com.sap.cds.feature.aicore.core.handler.AICoreApplicationServiceHandler;
import com.sap.cds.feature.aicore.core.handler.ActionHandler;
import com.sap.cds.feature.aicore.core.handler.ConfigurationHandler;
Expand Down Expand Up @@ -48,7 +52,14 @@ public void services(CdsRuntimeConfigurer configurer) {

if (hasBinding) {
AICoreServiceImpl service =
new AICoreServiceImpl(AICoreService.DEFAULT_NAME, runtime, multiTenancyEnabled);
new AICoreServiceImpl(
AICoreService.DEFAULT_NAME,
runtime,
multiTenancyEnabled,
new DeploymentApi(),
new ConfigurationApi(),
new ResourceGroupApi(),
new AiCoreService());
configurer.service(service);
logger.info("Registered AICoreService backed by AI Core binding.");
} else {
Expand Down
17 changes: 12 additions & 5 deletions cds-feature-ai-core/src/main/java/com/sap/cds/feature/aicore/core/AICoreServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,14 @@ public class AICoreServiceImpl extends AbstractAICoreService {
private final ResourceGroupApi resourceGroupApi;
private final AiCoreService sdkService;

public AICoreServiceImpl(String name, CdsRuntime runtime, boolean multiTenancyEnabled) {
public AICoreServiceImpl(
String name,
CdsRuntime runtime,
boolean multiTenancyEnabled,
DeploymentApi deploymentApi,
ConfigurationApi configurationApi,
ResourceGroupApi resourceGroupApi,
AiCoreService sdkService) {
super(name, runtime);
this.multiTenancyEnabled = multiTenancyEnabled;
CdsEnvironment env = runtime.getEnvironment();
Expand All @@ -82,10 +89,10 @@ public AICoreServiceImpl(String name, CdsRuntime runtime, boolean multiTenancyEn
this.tenantResourceGroupCache = newCache();
this.resourceGroupDeploymentCache = newCache();
this.deploymentLocks = newCache();
this.deploymentApi = new DeploymentApi();
this.configurationApi = new ConfigurationApi();
this.resourceGroupApi = new ResourceGroupApi();
this.sdkService = new AiCoreService();
this.deploymentApi = deploymentApi;
this.configurationApi = configurationApi;
this.resourceGroupApi = resourceGroupApi;
this.sdkService = sdkService;
Comment thread
Schmarvinius marked this conversation as resolved.
}

private static <V> Cache<String, V> newCache() {
Expand Down
Loading