Skip to content

feat(core-acs-reader): support active contracts pagination#1947

Merged
mateuszpiatkowski-da merged 10 commits into
mainfrom
mateuszpiatkowski-da/support-active-contracts-pagination
Jun 8, 2026
Merged

feat(core-acs-reader): support active contracts pagination#1947
mateuszpiatkowski-da merged 10 commits into
mainfrom
mateuszpiatkowski-da/support-active-contracts-pagination

Conversation

@mateuszpiatkowski-da

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da mateuszpiatkowski-da self-assigned this Jun 6, 2026
@mateuszpiatkowski-da mateuszpiatkowski-da linked an issue Jun 6, 2026 that may be closed by this pull request
@mateuszpiatkowski-da mateuszpiatkowski-da marked this pull request as ready for review June 6, 2026 18:47
@mateuszpiatkowski-da mateuszpiatkowski-da requested a review from a team as a code owner June 6, 2026 18:47
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@pawelstepien-da pawelstepien-da self-requested a review June 8, 2026 07:43
@mateuszpiatkowski-da

Copy link
Copy Markdown
Contributor Author

FYI this will be tested as part of #1924

Comment thread core/acs-reader/src/service.ts Outdated
Comment thread core/acs-reader/src/cache/item/paginatedItem.ts Outdated
Comment thread core/acs-reader/src/cache/item/base.ts Outdated
Comment thread core/acs-reader/src/reader/reader.ts Outdated
@pawelstepien-da

Copy link
Copy Markdown
Contributor

At some point I would love to have a high level overview in README. It would help a lot in getting up to speed with comprehending this module.

Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da

Copy link
Copy Markdown
Contributor Author

At some point I would love to have a high level overview in README. It would help a lot in getting up to speed with comprehending this module.

@pawelstepien-da I'll add the readme shortly as well

Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
pawelstepien-da
pawelstepien-da previously approved these changes Jun 8, 2026
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da mateuszpiatkowski-da merged commit 3b67015 into main Jun 8, 2026
27 checks passed
@mateuszpiatkowski-da mateuszpiatkowski-da deleted the mateuszpiatkowski-da/support-active-contracts-pagination branch June 8, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support active contracts pagination

2 participants