Skip to content

refactor(wallet-sdk): remove default synchronizer auto-selection#1740

Open
jarekr-da wants to merge 69 commits into
wiktor/multisync-examplefrom
jarekr/sdk_synchronizers
Open

refactor(wallet-sdk): remove default synchronizer auto-selection#1740
jarekr-da wants to merge 69 commits into
wiktor/multisync-examplefrom
jarekr/sdk_synchronizers

Conversation

@jarekr-da

@jarekr-da jarekr-da commented May 13, 2026

Copy link
Copy Markdown
Contributor
  1. No automatic selection of synchonizer in wallet sdk code - if synchronizer is not explicitly provided by caller - we rely on canon ledger choice of synchronizer. There is no extra logic of choosing synchonizer in wallet sdk
  2. tests code changed to explicitly set synchronizer

Note:

This complicates all existing tests. Code must now explicitly select synchronizer in many calls.

Alternative would be to start some tests in single synchronizer (but this also means, such test would fail randomly if run on multi synchronizer localnet).

@jarekr-da jarekr-da changed the title All tests use multi-sync Removed default synchronizer Id May 18, 2026
@jarekr-da jarekr-da changed the title Removed default synchronizer Id Removed default synchronizer May 18, 2026
@jarekr-da jarekr-da force-pushed the jarekr/sdk_synchronizers branch from 97545e9 to 3ae7ca0 Compare May 20, 2026 13:51
@jarekr-da jarekr-da force-pushed the wiktor/multisync-example branch from 563df2d to 98dfc85 Compare May 20, 2026 17:18
jarekr-da and others added 25 commits May 21, 2026 07:38
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…e synchronizers

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…existing vetPackage()

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…for examples and added ID of TransferFactory from this project in Exmple 15. Also removed buildContractReadSpec() and its usages

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…global during settlement of Trade

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…to Ledger Namespace

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…s of Wallet SDK

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…at could happen in unassign method

Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: Viktor-Kalashnykov-da <viktor.kalashnykov@digitalasset.com>
* fix: eliminate copying of dars from global to app synchronizer

Signed-off-by: Marcin Ziolek <marcin.ziolek@digitalasset.com>

* fix: elmininate the need for custom bootstrap script completely

Signed-off-by: Marcin Ziolek <marcin.ziolek@digitalasset.com>

---------

Signed-off-by: Marcin Ziolek <marcin.ziolek@digitalasset.com>
@jarekr-da jarekr-da self-assigned this Jun 9, 2026
@jarekr-da jarekr-da force-pushed the jarekr/sdk_synchronizers branch from a84acce to fa21b86 Compare June 9, 2026 13:12
@jarekr-da jarekr-da changed the title Removed default synchronizer refactor(wallet-sdk): remove default synchronizer auto-selection Jun 9, 2026
@jarekr-da jarekr-da force-pushed the jarekr/sdk_synchronizers branch from 03037fb to f95afe5 Compare June 9, 2026 18:11
…s TestToken before app-synchronizer self-transfer in run-15

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
@jarekr-da jarekr-da force-pushed the jarekr/sdk_synchronizers branch from 7c58d39 to 452af4a Compare June 10, 2026 10:28
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…sync flag from run-15 usage

Multi-sync is now the default for start:localnet; --no-multi-sync starts single-synchronizer debug mode.

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
@jarekr-da

Copy link
Copy Markdown
Contributor Author

Check - where syncId is really needed by canton.

jarekr-da added 12 commits June 10, 2026 16:10
…out test token

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…vide synchronizerId

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…examples and snippets

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
… for multi-sync

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…Id to DAR uploads in upload-dars

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…Id to DAR uploads and external party creation

The wallet SDK no longer auto-selects a synchronizer. DAR upload and external party creation now require an explicit synchronizerId, which fails on multi-sync participants otherwise. Resolve the global synchronizer via getGlobalSynchronizerId and pass it to dar.upload and party.external.create across the affected example scripts.

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…arty creation in scripts 08, 09, 12 and stress 01

Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
@jarekr-da jarekr-da force-pushed the jarekr/sdk_synchronizers branch 2 times, most recently from 0256183 to 51c5d16 Compare June 15, 2026 15:54
@jarekr-da jarekr-da marked this pull request as ready for review June 16, 2026 07:15
@jarekr-da jarekr-da requested a review from a team as a code owner June 16, 2026 07:15
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
@jarekr-da jarekr-da force-pushed the wiktor/multisync-example branch from 93653ae to 1bee65e Compare June 17, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants