Skip to content

test(wallet): make TransferPreapproval failure test robust to validator timeout #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
samsondav wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −9
Draft

test(wallet): make TransferPreapproval failure test robust to validator timeout #5988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions .../test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.lfdecentralizedtrust.splice.wallet.store.{
import com.digitalasset.canton.config.RequireTypes.PositiveInt
import com.digitalasset.canton.console.CommandFailure
import com.digitalasset.canton.data.CantonTimestamp
import com.digitalasset.canton.logging.SuppressingLogger.LogEntryOptionality
import com.digitalasset.canton.logging.SuppressionRule
import com.digitalasset.canton.topology.{PartyId, SynchronizerId}
import com.digitalasset.canton.{HasExecutionContext, SynchronizerAlias}
Expand Down Expand Up @@ -693,26 +694,37 @@ class WalletIntegrationTest
aliceValidatorBackend.lookupTransferPreapprovalByParty(aliceUserParty) shouldBe None
aliceTransferPreapprovalProposals should be(empty)

// Once validator automation is paused the request cannot complete. The intended outcome is
// a 429 once the server-side retry loop gives up. Under load the validator's HTTP request
// timeout can fire first, in which case the server logs a WARN "resulted in a timeout" and
// returns a 503 instead. Accept either failure (both surface the request as a logged ERROR)
// and tolerate the optional timeout WARN, so a slow CI host does not flake the assertion.
def assertCreateTransferPreapprovalFails(): Unit =
loggerFactory.assertThrowsAndLogsUnorderedOptional[CommandFailure](
aliceWalletClient.createTransferPreapproval(),
LogEntryOptionality.Required -> { entry =>
entry.errorMessage should (include("429 Too Many Requests") or
include("503 Service Unavailable"))
},
LogEntryOptionality.Optional -> { entry =>
entry.warningMessage should include("resulted in a timeout")
},
)

// Disable validator automation to create the TransferPreapproval.
// This implies the request from alice will not succeed and time out.
bracket(
acceptTransferPreapprovalProposalTrigger.pause().futureValue,
acceptTransferPreapprovalProposalTrigger.resume(),
) {
val proposalCid =
clue("createTransferPreapproval fails with HTTP 429 if validator automation fails") {
assertThrowsAndLogsCommandFailures(
aliceWalletClient.createTransferPreapproval(),
_.errorMessage should include("429 Too Many Requests"),
)
clue("createTransferPreapproval fails if validator automation fails") {
assertCreateTransferPreapprovalFails()
aliceTransferPreapprovalProposals should have length 1
aliceTransferPreapprovalProposals.head.id
}
clue("TransferPreapprovalProposals created via the wallet API are deduplicated") {
assertThrowsAndLogsCommandFailures(
aliceWalletClient.createTransferPreapproval(),
_.errorMessage should include("429 Too Many Requests"),
)
assertCreateTransferPreapprovalFails()
aliceTransferPreapprovalProposals should have length 1
aliceTransferPreapprovalProposals.head.id shouldBe proposalCid
}
Expand Down