Skip to content

Re-enable automaticSilentRenew on OidcAuthProvider#5937

Merged
pawelperek-da merged 3 commits into
canton-network:mainfrom
Avro-Digital:sam-avro/issue-5682-silent-renew
Jun 16, 2026
Merged

Re-enable automaticSilentRenew on OidcAuthProvider#5937
pawelperek-da merged 3 commits into
canton-network:mainfrom
Avro-Digital:sam-avro/issue-5682-silent-renew

Conversation

@samsondav

@samsondav samsondav commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

PR #5545 disabled automaticSilentRenew when removing the global offline_access scope. Keycloak still issues a session-bound refresh token without that scope, so silent renew can use the refresh_token grant and users are no longer forced back to the IdP on every short access-token expiry (default 5 minutes).

Fixes #5682

Change

Re-enable automaticSilentRenew on OidcAuthProvider.

Testing

AuthProvider.test.tsx mocks react-oidc-context and asserts automaticSilentRenew: true is passed through. Also covers the hs256-unsafe short-circuit path.

Note

This is the minimal fix Pawel asked for in lieu of #5683, which adds per-IdP enable_offline_scope configuration and operator docs. Auth0 deployments that require offline_access to receive a refresh token may still need a follow-up if silent renew does not work there without that scope.

@pawelperek-da pawelperek-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samsondav

Copy link
Copy Markdown
Contributor Author

The wall-clock-time (0) CI failure here is an unrelated flaky test, not caused by this PR (which only touches the frontend AuthProvider).

WalletIntegrationTest › "Failure to complete TransferPreapproval creation should be handled correctly" failed because the validator HTTP server timed out under CI load (38s → 503) and logged a WARN "resulted in a timeout" entry, which broke the test's strict ERROR-level log assertion. Failed job: https://github.com/canton-network/splice/actions/runs/27450544466/job/81436663390

Fix for the flake itself: #5988. Re-running CI on this PR should clear it in the meantime.

Signed-off-by: Sam Davies <sam@avrofi.com>
Signed-off-by: Sam Davies <sam@avrofi.com>
Signed-off-by: Sam Davies <sam@avrofi.com>
@samsondav samsondav force-pushed the sam-avro/issue-5682-silent-renew branch from e3bb6a6 to 4a0380a Compare June 16, 2026 14:49
@pawelperek-da pawelperek-da merged commit b93b2e1 into canton-network:main Jun 16, 2026
126 of 129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starting from 0.6.5 all UIs require re-login after access token expires

6 participants