SvApp: For TBA use total app activity in SummarizingMiningRoundTrigger#5903
Open
dfordivam wants to merge 12 commits into
Open
SvApp: For TBA use total app activity in SummarizingMiningRoundTrigger#5903dfordivam wants to merge 12 commits into
dfordivam wants to merge 12 commits into
Conversation
Contributor
Author
|
@meiersi-da This draft PR is ready for a first look. The CI won't pass on this yet, as it require TBA bootstrap support. |
meiersi-da
reviewed
Jun 12, 2026
dfordivam
force-pushed
the
dfordivam/cip-104-summarizing-totals
branch
from
5f2b235 to
610cfaa
Compare
dfordivam
force-pushed
the
dfordivam/cip-104-summarizing-totals
branch
from
38588fe to
8f5ac9e
Compare
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam
force-pushed
the
dfordivam/cip-104-summarizing-totals
branch
from
8f5ac9e to
c1574c8
Compare
Contributor
Author
|
@meiersi-da This PR is ready for review! |
meiersi-da
approved these changes
Jun 16, 2026
| type: integer | ||
| format: int64 | ||
| total_app_reward_minting_allowance: | ||
| type: string |
Contributor
There was a problem hiding this comment.
Suggested change
| type: string | |
| type: string | |
| description: The total of all minting allowances granted to app providers in this round. |
| total_app_reward_minting_allowance: | ||
| type: string | ||
| total_app_reward_thresholded: | ||
| type: string |
Contributor
There was a problem hiding this comment.
Suggested change
| type: string | |
| type: string | |
| description: Total amount of minting allowances that fell below the configured app reward threshold and was thus burned. |
| total_app_reward_thresholded: | ||
| type: string | ||
| total_app_reward_unclaimed: | ||
| type: string |
Contributor
There was a problem hiding this comment.
Suggested change
| type: string | |
| type: string | |
| description: Total amount of app rewards which could not be attributed to app providers in this round because of limit on app rewards per activity (aka the app rewards cap). |
| // We should never hit this, as both activity totals and round | ||
| // totals are added in a single DB Tx | ||
| ScanResource.GetRewardAccountingActivityTotalsResponse.OK( | ||
| definitions.GetRewardAccountingActivityTotalsResponse( |
Contributor
There was a problem hiding this comment.
consider defining shared constants for undetermined and cannotProvide
| response <- bftScan.getRewardAccountingActivityTotals(round) | ||
| } yield response match { | ||
| case RewardAccountingActivityTotalsOk(ok) => | ||
| logger.info(s"Obtained the reward accounting totals for round $round via BFT read.") |
Contributor
There was a problem hiding this comment.
please also add a metric for this one alongside the ones that were added recently for the other two calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5849
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines