fix(search): escape LIKE wildcards and fix match highlighting#488
Open
leno23 wants to merge 1 commit into
Open
fix(search): escape LIKE wildcards and fix match highlighting#488leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Searching for `_` used SQL LIKE wildcards, matching unrelated commands with multi-byte characters and producing invalid byte match indices that could panic when rendering results. Escape `%` and `_` in LIKE patterns and compute highlight indices at Unicode character boundaries. Fixes cantino#441 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_with fuzzy matching used SQLLIKEwhere_is a single-character wildcard, so unrelated commands (e.g. box-drawing│characters) were returned.index..index + cmd.len()), which can fall inside multi-byte UTF-8 characters and panic when rendering results.%and_inLIKEpatterns (ESCAPE '\\') and compute highlight indices at Unicode character boundaries.Fixes #441
Test plan
cargo testescape_like, char-boundary match indices, and fuzzy_matching