fix(zsh): join multiline extended history entries#487
Open
leno23 wants to merge 1 commit into
Open
Conversation
When zsh extended history is enabled, continuation lines without a timestamp prefix belong to the previous command. Parse and join them instead of treating each physical line as a separate command. Fixes cantino#87 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #87.
When zsh extended history is enabled, multiline commands are stored as a timestamped first line followed by continuation lines without timestamps. McFly previously treated each physical line as a separate command, so multiline entries were split and often only the last line was searchable.
This change joins continuation lines into a single command when
extended_historyis enabled. Separate commands that happen to end with\remain distinct because each has its own timestamp line.Test plan
cargo test shell_history