Skip to content

feat(dex): cap LP providers with deterministic replacement #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnguyen22 merged 9 commits into from
Jul 23, 2026
Merged

feat(dex): cap LP providers with deterministic replacement #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6799d24
feat(dex): cap liquidity providers with deterministic eviction
andrewnguyen22 Jul 21, 2026
cb6ccea
added comments
andrewnguyen22 Jul 21, 2026
d8c7de2
Merge remote-tracking branch 'origin/main' into feat/dex-lp-provider-cap
andrewnguyen22 Jul 21, 2026
f59e0bd
fix(dex): address LP cap review feedback
andrewnguyen22 Jul 22, 2026
434175e
fix(dex): keep legacy migration persistence simple
andrewnguyen22 Jul 22, 2026
5e3c606
docs(dex): explain legacy LP migration flow
andrewnguyen22 Jul 22, 2026
4fcbffa
refactor(dex): name LP migration ID domain
andrewnguyen22 Jul 22, 2026
3b648a6
refactor(dex): isolate legacy LP migration
andrewnguyen22 Jul 22, 2026
b0da298
refactor(dex): group capped deposit helpers
andrewnguyen22 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/rpc/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,15 @@ func (s *Server) Transaction(w http.ResponseWriter, r *http.Request, _ httproute
// Transactions handles multiple transactions in a single request
func (s *Server) Transactions(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
// create a slice to hold the incoming transactions
var txs []lib.TransactionI
var transactions []*lib.Transaction

@rem1niscence rem1niscence Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the logic behind using the concrete type? when I first made this change I used the interface in order to avoid the iteration done now to cast to the concrete type as a small optimization, any reason to do this?

@andrewnguyen22 andrewnguyen22 Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to keep the interface here too, but encoding/json can't instantiate entries in []lib.TransactionI, so normal tx objects fail to decode on the batch endpoint. Decoding into []*lib.Transaction gives it a concrete target. The loop is only wrapping pointers in the interface slice, not copying the txs, and keeps us from needing a custom decoder or a wider submitTxs change.

// unmarshal the HTTP request body into the transactions slice
if ok := unmarshal(w, r, &txs); !ok {
if ok := unmarshal(w, r, &transactions); !ok {
return
}
txs := make([]lib.TransactionI, len(transactions))
for i := range transactions {
txs[i] = transactions[i]
}
// submit transactions to RPC server
s.submitTxs(w, txs)
}
Expand Down
Loading
Loading