Skip to content

Guard transaction replay height overflow #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giwaov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard transaction replay height overflow #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion fsm/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func (s *StateMachine) CheckReplay(tx *lib.Transaction, txHash string) lib.Error
}
}
// this gives the protocol a theoretically safe tx indexer prune height
maxHeight, minHeight := s.Height()+BlockAcceptanceRange, uint64(0)
maxHeight, minHeight := maxAcceptedTxHeight(s.Height()), uint64(0)
// if height is after the BlockAcceptanceRange blocks
if s.Height() > BlockAcceptanceRange {
// update the minimum height
Expand All @@ -257,6 +257,13 @@ func (s *StateMachine) CheckReplay(tx *lib.Transaction, txHash string) lib.Error
return nil
}

func maxAcceptedTxHeight(height uint64) uint64 {
if height > math.MaxUint64-BlockAcceptanceRange {
return math.MaxUint64
}
return height + BlockAcceptanceRange
}

// CheckMessage() performs basic validations on the msg payload
func (s *StateMachine) CheckMessage(msg *anypb.Any) (message lib.MessageI, err lib.ErrorI) {
// ensure the message isn't nil
Expand Down
10 changes: 10 additions & 0 deletions fsm/transaction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,16 @@ func TestCheckReplay(t *testing.T) {
},
height: 122,
},
{
name: "maximum height overflow guard",
detail: "near max uint64 height should not wrap the maximum accepted tx height",
tx: &lib.Transaction{
CreatedHeight: math.MaxUint64 - 1,
NetworkId: 1,
ChainId: 1,
},
height: math.MaxUint64 - 1,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
Expand Down