Frontend charm integration tests fix with a self hosted runner - #80
Merged
Conversation
…n blocked status (more scenarios needed to actually relate the frontend to the backend).
…ger the integration tests with.
… action is required.
…state where relation is not yet connected. Simplified the charm logic, no _stored state needed (fetching the hostname and port from the relation's application data bag).
Let's try with the microk8s version and libpyjuju < 3.1 that seems to work for rout53-acme-operator where the integration test pipeline is pulled from
…rver into integration-test-fix
The workflow depends on self hosted runner and composite actions introduced in https://github.com/canonical/certification-github-workflows
…:canonical/test_observer into integration-test-fix-with-hosted-runners
…R review has been submitted
…es to resources under frontend/charm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests for the frontend charm now actually work also on GitHub!
The workflow is stable, with a dozen passes with no intermittent failures over the last few days.
It does however take ~10mins to run and I figured we would therefore not start running it on every commit to every branch (6+ mins of the time is taken by the microk8s setup -- we can drop this in a big way with custom images used for the CI runs when that becomes available). It runs on:
./frontend/charm(the integration tests can capture failures also in resources outside that directory, hence the rule above also).The workflow was refactored to reuse two now introduced reusable composite actions in https://github.com/canonical/certification-github-workflows (the first PR to that repo should be reviewed and merged first before this goes in).
NOTE! When squashing this into main, please edit the commit message heavily down in volume since this contains a few months worth of desperate debugging attempts of these integration tests that continued to work locally just fine but failed to be executed specifically on GitHub up until now. I have simplified the version history with some squashing but since there are several merge commits there I didn't want to do anything more drastic than that.
(Re-posted this to supersede #54 -- @plars has gone on much deserved holidays and I had addressed all his valid concerns and questions, with the PR unfortunately left in "changes requested" state)