Skip to content

fix(frontend): make bulk-review env list scrollable above max-height (#736) #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanookclaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(frontend): make bulk-review env list scrollable above max-height (#736) #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions frontend/lib/ui/artefact_page/bulk_environment_review_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,28 +112,34 @@ class _BulkEnvironmentReviewDialogState
border: Border.all(color: Colors.grey[300]!),
borderRadius: BorderRadius.circular(4),
),
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
for (var i = 0; i < widget.environments.length; i++) ...[
Padding(
padding: const EdgeInsets.symmetric(
horizontal: Spacing.level2,
vertical: Spacing.level1,
),
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'${widget.environments[i].environment.name} '
'(${widget.environments[i].environment.architecture})',
style: Theme.of(context).textTheme.bodySmall,
constraints: const BoxConstraints(maxHeight: 240),
child: Scrollbar(
thumbVisibility: true,
child: SingleChildScrollView(
child: Column(
Comment on lines +116 to +119
mainAxisSize: MainAxisSize.min,
children: [
Comment on lines +115 to +121
for (var i = 0; i < widget.environments.length; i++) ...[
Padding(
padding: const EdgeInsets.symmetric(
horizontal: Spacing.level2,
vertical: Spacing.level1,
),
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'${widget.environments[i].environment.name} '
'(${widget.environments[i].environment.architecture})',
style: Theme.of(context).textTheme.bodySmall,
),
),
),
),
),
if (i != widget.environments.length - 1)
Divider(height: 1, color: Colors.grey[300]),
],
],
if (i != widget.environments.length - 1)
Divider(height: 1, color: Colors.grey[300]),
],
],
),
),
),
),
const SizedBox(height: Spacing.level4),
Expand Down