Skip to content

feat: Generic COS assertions function#351

Merged
MichaelThamm merged 3 commits into
mainfrom
feat/tf-generic-assertions
May 20, 2026
Merged

feat: Generic COS assertions function#351
MichaelThamm merged 3 commits into
mainfrom
feat/tf-generic-assertions

Conversation

@MichaelThamm
Copy link
Copy Markdown
Contributor

@MichaelThamm MichaelThamm commented May 19, 2026

Issue

We have many tests doing the same assertions.

Solution

In attempt to be more DRY I added a generic_assertions free function that accepts the correct args to execute all the assertions agnostic to the product flavors:

  • COS
  • COS Lite
  • COS Dev

Any assertions that are specific to a flavor should remain free and called in relevant tests e.g., no_errors_in_otelcol_logs because COS Lite has no otelcol app.

Checklist

  • I have added or updated relevant documentation.
  • PR title makes an appropriate release note and follows conventional commits syntax.
  • Merge target is the correct branch, and relevant tandem backport PRs opened.

Context

Testing Instructions

Upgrade Notes

@MichaelThamm MichaelThamm marked this pull request as ready for review May 19, 2026 17:24
@MichaelThamm MichaelThamm requested a review from a team as a code owner May 19, 2026 17:24
Comment thread terraform/cos/locals.tf Outdated
Copy link
Copy Markdown
Contributor

@lucabello lucabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Michael Thamm <mike.thamm@canonical.com>
@MichaelThamm MichaelThamm merged commit b9382d1 into main May 20, 2026
1 check passed
@MichaelThamm MichaelThamm deleted the feat/tf-generic-assertions branch May 20, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants