feat: Generic COS assertions function#351
Merged
Merged
Conversation
MichaelThamm
commented
May 19, 2026
Signed-off-by: Michael Thamm <mike.thamm@canonical.com>
MichaelThamm
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We have many tests doing the same assertions.
Solution
In attempt to be more DRY I added a
generic_assertionsfree function that accepts the correct args to execute all the assertions agnostic to the product flavors:Any assertions that are specific to a flavor should remain free and called in relevant tests e.g.,
no_errors_in_otelcol_logsbecause COS Lite has no otelcol app.Checklist
Context
Testing Instructions
Upgrade Notes