fix: handle multiple istio-ingress-route relations in jupyter-ui#576
Merged
NohaIhab merged 5 commits intoJun 17, 2026
Merged
Conversation
ckfbot
added
backport track/1.10
Contributor
🤖 Backport labels populatedLabels to this pull request were added automatically by the When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR. |
Contributor
|
question: was this also tested on real deployment / integration tests with multiple integrations? |
Deploy a second istio-ingress-k8s instance, relate it to jupyter-ui's istio-ingress-route endpoint, and assert the resulting HTTPRoute is created and attached to the second Gateway via parentRefs. Adjust concierge MetalLB CIDR to provide two IPs, one per Istio ingress gateway.
Contributor
Author
|
@dariofaccin yes I've validated it locally, and now added integration tests too. Thanks! |
MattiaSarti
requested changes
Jun 15, 2026
MattiaSarti
approved these changes
Jun 17, 2026
dariofaccin
approved these changes
Jun 17, 2026
dariofaccin
left a comment
dariofaccin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the thorough integration tests.
NohaIhab
deleted the
kf-8750-handle-multiple-istio-ingress-route-relations
branch
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of canonical/bundle-kubeflow#1446
Use
model.relations[...]instead ofmodel.get_relation(...)when checking ingress relations, so the charm no longer raisesTooManyRelatedAppsErrorwhen more than oneistio-ingress-routerelation is present.Add unit tests covering multiple
istio-ingress-routerelations and verifying each relation receives a validHTTPRouteconfig.Note: this PR will be replicated to all our charm that relate to
istio-ingress-route, once approved