Skip to content

fix: use 443 for tls for jupyter-ui relation on istio-ingress-route#573

Merged
NohaIhab merged 3 commits into
mainfrom
kf-8724/fix-use-443-for-tls
Jun 10, 2026
Merged

fix: use 443 for tls for jupyter-ui relation on istio-ingress-route#573
NohaIhab merged 3 commits into
mainfrom
kf-8724/fix-use-443-for-tls

Conversation

@NohaIhab

@NohaIhab NohaIhab commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Part of canonical/bundle-kubeflow#1441

Changes

  • Set the ingress listener port to 443 when ingress.tls_enabled, else 80.
  • Add a parametrized unit test covering both the TLS-enabled (443) and TLS-disabled (80) cases.

@NohaIhab NohaIhab requested a review from a team June 9, 2026 10:28
@ckfbot ckfbot added backport track/1.10 Backport to track/1.10 backport track/1.11 Backport to track/1.11 labels Jun 9, 2026
@ckfbot

ckfbot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Backport labels populated

Labels to this pull request were added automatically by the populate-labels.yaml action.

When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR.

@NohaIhab NohaIhab requested a review from a team June 10, 2026 07:14
@NohaIhab NohaIhab removed the backport track/1.10 Backport to track/1.10 label Jun 10, 2026
@NohaIhab NohaIhab merged commit 0cc8892 into main Jun 10, 2026
22 checks passed
@NohaIhab NohaIhab deleted the kf-8724/fix-use-443-for-tls branch June 10, 2026 11:02
@ckfbot ckfbot mentioned this pull request Jun 10, 2026
Merged
@ckfbot

ckfbot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for track/1.11:

NohaIhab added a commit that referenced this pull request Jun 10, 2026
@NohaIhab
fix: use 443 for tls for jupyter-ui relation on `istio-ingress-rout…
28fdf16 
…e` (backport #573) (#575)

# Description
Backport of #573 to `track/1.11`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dariofaccin dariofaccin dariofaccin approved these changes
@mvlassis mvlassis mvlassis approved these changes

Assignees

No one assigned

Labels

backport track/1.11 Backport to track/1.11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NohaIhab @ckfbot @dariofaccin @mvlassis