chore: MAAS as a snap only - drop install_type from websockets#6110
Conversation
nehjoshi
left a comment
There was a problem hiding this comment.
Looks good for the most part. There are still some trailing references to install_type to remove:
-
src/app/store/controller/types/enum.ts: Since we only support snap, we can remove the enum entirely as it leaves only 1 option -
src/app/store/controller/types/base.ts: Removeinstall_typefromControllerVersions -
src/app/controllers/views/ControllerList/components/VersionColumn/VersionColumn.tsx: Conditionally renders controller install type -
src/app/base/components/node/OverviewCard/ControllerStatusCard/ControllerStatusCard.tsx: We can display the snap channel directly without checking ifinstall_type==='deb'. -
Some references to install_type can be removed from
src/app/base/components/node/OverviewCard/ControllerStatusCard/ControllerStatusCard.test.tsx
|
Thanks! I addressed the comments and re-tested |
Done
install_type, as every controller is supposed to be running in a snap env in 4.0. So I removedinstall_typeand all the logics around thatQA steps