Skip to content

chore: MAAS as a snap only - drop install_type from websockets#6110

Merged
r00ta merged 3 commits into
canonical:mainfrom
r00ta:bye-debs
Jul 24, 2026
Merged

chore: MAAS as a snap only - drop install_type from websockets#6110
r00ta merged 3 commits into
canonical:mainfrom
r00ta:bye-debs

Conversation

@r00ta

@r00ta r00ta commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Done

  • In the backend we removed install_type, as every controller is supposed to be running in a snap env in 4.0. So I removed install_type and all the logics around that
  • updated the image source keyring path, as it'll be always the snap one

QA steps

@r00ta
r00ta marked this pull request as ready for review July 23, 2026 22:12
@r00ta r00ta changed the title chore: MAAS as a snap only - drop install_type method chore: MAAS as a snap only - drop install_type from websockets Jul 24, 2026

@nehjoshi nehjoshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. There are still some trailing references to install_type to remove:

  • src/app/store/controller/types/enum.ts: Since we only support snap, we can remove the enum entirely as it leaves only 1 option

  • src/app/store/controller/types/base.ts: Remove install_type from ControllerVersions

  • src/app/controllers/views/ControllerList/components/VersionColumn/VersionColumn.tsx: Conditionally renders controller install type

  • src/app/base/components/node/OverviewCard/ControllerStatusCard/ControllerStatusCard.tsx: We can display the snap channel directly without checking if install_type==='deb'.

  • Some references to install_type can be removed from src/app/base/components/node/OverviewCard/ControllerStatusCard/ControllerStatusCard.test.tsx

@r00ta

r00ta commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I addressed the comments and re-tested

@r00ta
r00ta requested a review from nehjoshi July 24, 2026 08:14

@nehjoshi nehjoshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r00ta
r00ta merged commit bfbd489 into canonical:main Jul 24, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants