chore: pin charm dependencies in tests (track/1.16)#403
Merged
Conversation
bd97dab to
597a5be
Compare
MattiaSarti
approved these changes
May 25, 2026
MattiaSarti
left a comment
Contributor
There was a problem hiding this comment.
note: this track of this charm is used both in CKF 1.10 and in CKF 1.11, but they rely on different tracks for some of these dependency charms, so I am approving because this is coherent with CKF 1.11, but I'd like to hear the opinion of a second reviewer
NohaIhab
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the track of charm dependencies in tests.
External (resolved via Terraform Solutions track/1.11)
istio-gateway:1.24/stable→1.28/stableistio-pilot:1.24/stable→1.28/stableRefs: canonical/bundle-kubeflow#1379