Skip to content

chore(charm): Replace Traefik route with generic ingress#542

Draft
pedro-avalos wants to merge 9 commits into
mainfrom
chore-charm-generic-ingress
Draft

chore(charm): Replace Traefik route with generic ingress#542
pedro-avalos wants to merge 9 commits into
mainfrom
chore-charm-generic-ingress

Conversation

@pedro-avalos
Copy link
Copy Markdown
Collaborator

@pedro-avalos pedro-avalos commented May 29, 2026

Description

  • This PR replaces Traefik route with the generic ingress charm relation
  • Our use-cases and deployments benefit more from the generic ingress relation

Related Issue(s)

Testing

  • Unit tests
  • Integration testing

Checklist

  • I have followed the contribution guidelines.
  • I have signed the Canonical CLA.
  • I have added necessary tests.
  • I have added or updated any relevant documentation (if needed).
  • I have tested the changes.

Additional Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.17%. Comparing base (2aaeaeb) to head (1c81467).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   89.27%   89.17%   -0.10%     
==========================================
  Files          28       29       +1     
  Lines        1417     1423       +6     
  Branches        4        5       +1     
==========================================
+ Hits         1265     1269       +4     
- Misses        151      154       +3     
+ Partials        1        0       -1     
Flag Coverage Δ *Carryforward flag
charm 100.00% <ø> (ø) Carriedforward from 0464b18
client 80.24% <ø> (ø) Carriedforward from 0464b18
server 96.97% <ø> (-0.06%) ⬇️ Carriedforward from 0464b18

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
Server 96.85% <ø> (ø)
Charm 94.66% <92.68%> (-2.44%) ⬇️
Client 80.24% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread server/charm/lib/charms/traefik_k8s/v2/ingress.py Dismissed
Comment thread server/charm/lib/charms/traefik_k8s/v2/ingress.py Dismissed
Comment thread server/charm/lib/charms/traefik_k8s/v2/ingress.py Dismissed
Comment thread server/charm/lib/charms/traefik_k8s/v2/ingress.py Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant