feat: cache SHA3-384 entries#298
Open
upils wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR extends the internal cache to support multiple hashing algorithms (SHA-256 and SHA3-384) and updates callers/tests to specify which algorithm to use.
Changes:
- Introduced
hashAlgowith SHA-256 and SHA3-384 support, plus hash construction vianewHash. - Updated cache APIs (
Create,Write,Open,Read) to take an algorithm parameter and adjusted archive fetch code accordingly. - Added a test verifying SHA3-384 entries are isolated from SHA-256 entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/cache/cache.go | Adds multi-algorithm hashing support, updates cache APIs, and expires entries across algorithm directories. |
| internal/cache/cache_test.go | Updates tests to pass the algorithm and adds SHA3-384 isolation coverage. |
| internal/archive/archive.go | Updates cache usage in archive fetch path to specify SHA-256 algorithm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Binstore only publishes SHA3-384 hashes for bins. This PR enables storing entries in the cache using
SHA3-384 hashes. Consumers of the
cachepackage must now explicitly select the algorithm tobe used to create/write/read an entry.