feat: Add relation with s3 interface#335
Merged
Merged
Conversation
Contributor
🤖 Backport labels populatedLabels to this pull request were added automatically by the When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for relating argo-controller to S3 backends via the s3 interface (e.g., s3-integrator), while maintaining the existing object-storage path (e.g., MinIO), and updates tests/CI to cover both relation types.
Changes:
- Added
s3-credentialsrelation and logic to select/configure the active storage backend (S3 vs object-storage), including optional S3 region templating. - Split integration tests into dedicated suites for
s3-integratorandminioand updated CI to run both via a matrix. - Updated unit tests and dependency versions to support the new components.
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
charms/argo-controller/src/charm.py |
Adds S3 relation component + storage selection and updates template context generation. |
charms/argo-controller/metadata.yaml |
Declares the new s3-credentials required endpoint. |
charms/argo-controller/src/templates/minio_configmap.yaml.j2 |
Optionally injects S3 region into the artifact repository config. |
charms/argo-controller/tests/unit/test_charm.py |
Updates unit tests for optional storage relations, adds conflict-detector and endpoint parsing test. |
charms/argo-controller/tests/integration/test_charm_s3.py |
New integration suite covering s3-integrator:s3-credentials. |
charms/argo-controller/tests/integration/test_charm_object_storage.py |
New integration suite covering minio:object-storage. |
charms/argo-controller/tests/integration/charms_dependencies.py |
Adds S3_INTEGRATOR test dependency spec. |
charms/argo-controller/tox.ini |
Adds a new integration tox env and adjusts integration test targets. |
charms/argo-controller/pyproject.toml |
Bumps chisme version and adds a new dependency. |
.github/workflows/ci.yaml |
Runs both integration suites via a matrix strategy. |
.gitignore |
Ignores coverage.xml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>
NohaIhab
reviewed
Jun 22, 2026
NohaIhab
approved these changes
Jun 23, 2026
misohu
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3-credentialsrelation using thes3interface.RelationCountGateComponents.test_charm.py, which tests the relation withs3-integrator:s3-credentialstest_charm_object_storage.py, which tests the relation withminio:object-storageobject_storageands3in CICloses #318