problem_report: add CompressedFile.write()#610
Open
bdrung wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 84.37% 84.38%
=======================================
Files 106 106
Lines 21035 21047 +12
Branches 3220 3222 +2
=======================================
+ Hits 17749 17761 +12
Misses 2803 2803
Partials 483 483 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The method `decode_compressed_stream` is used outside of `CompressedValue`. Move this method to a stand-alone function to ease reusing it.
Add a `CompressedFile.write()` method to support this problem report value type in `Report.add_kernel_crash_info()`. This change is part of the wider approach to add type hints to `ProblemReport`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
CompressedFile.write()method to support this problem report value type inReport.add_kernel_crash_info().