A couple of small enhancements#181
Open
PJBrs wants to merge 5 commits into
Open
Conversation
The weight calculation omitted the weight of magic items. One would expect that this could be as simple as: weight += sum([m.weight for m in self.magic_items]). However, this doesn't work for magic items that are also added to self.weapons, since these would be counted twice in the weight calculation.
PJBrs
force-pushed
the
enhancements
branch
3 times, most recently
from
August 29, 2025 07:26
8d1c13f to
47aaf18
Compare
Contributor
Author
|
I redid this PR, and I don't think this is done clumsily anymore. I added one patch that enables a users feature to be a FeatureSelector, as a prerequisite for implementing Resilient. |
In recent changes, the calculation for carrying weight now better takes into account magic items and weapons. Add this to the tests, and also check the new weight_and_capacity_text code.
This allows a feature selected by a player (that is, non-class, non-race) to be a FeatureSelectore. This is necessary to implement, for instance, Resilient, which would be a FeatureSelector where the chosen Ability in which the character becomes resilient is then set in feature_choices.
Implement Resilient as a feature selector, add the various options for resilient as features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of small enhancements:
Those last two, I may have done a bit clumsily.