Issue 134 authorship#135
Open
turbomam wants to merge 7 commits into
Open
Conversation
test_ObservationSet.json untested
merging in main why7 comment needed?
does Poetry read the package's author data from this setup.cfg? Or pyproject.toml?
merging main into stale branch before resuming work in branch
Member
Author
|
@gaurav @sujaypatil96 I'm ready for your review. Somehow this authorship issue & PR got contaminated with some tests I wrote, but those are probably harmless and maybe even useful. |
sujaypatil96
approved these changes
Nov 22, 2021
sujaypatil96
left a comment
sujaypatil96
left a comment
Contributor
There was a problem hiding this comment.
I ran all your tests and everything passed seamlessly @turbomam. Thank you for the tests and also the modifications to the TOML file. Feel free to merge this PR when you're ready.🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change author from MAM to GV for issue #134
does Poetry read the package's author data from this setup.cfg? Or pyproject.toml?