chore(deps): pin ngtcp2 by commit sha instead of mutable tag - #155
Merged
Conversation
jamofer
force-pushed
the
chore/sec10-pin-ngtcp2-sha
branch
from
July 21, 2026 21:48
cc92bcd to
d012f29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin the ngtcp2 FetchContent dependency to commit SHA
454390e(v1.23.0) instead of the mutableGIT_TAG v1.23.0.Why
Supply-chain hygiene (audit SEC-10). ngtcp2 was the only dependency pinned by a git tag, which a tag owner can move; sqlite is already
URL_HASH-pinned. A moved tag would silently alter the build on a fresh checkout.How
GIT_TAG v1.23.0→GIT_TAG 454390edaf6c954a101aa77961a939dd9e338ad2 # v1.23.0(the dereferenced commit of the v1.23.0 annotated tag).Testing
make releasereconfigures + builds clean at the pinned SHANotes
No code change. Same tree as before — the SHA is exactly what v1.23.0 pointed to.