fix(worktree): use main repo root for worktree naming - #156
Merged
Conversation
When `isq start` was run from within an existing worktree, `repo.workdir()` returned the current worktree's path instead of the main repo root. This caused new worktree names to append to the current worktree name, producing absurdly long paths like `wrk-537-chat-goes-off-rails-and-page-404-WRK-536-investigate-...`. Fix by using `repo.common_dir()` (which always resolves to the main repo's .git directory) to derive the repo name and parent, consistent with what `detect_repo_path()` already does. https://claude.ai/code/session_01A59eHjgbg2LRBLysFD3Cmp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
isq startwas run from within an existing worktree,repo.workdir()returned the current worktree's path instead of themain repo root. This caused new worktree names to append to the current
worktree name, producing absurdly long paths like
wrk-537-chat-goes-off-rails-and-page-404-WRK-536-investigate-....Fix by using
repo.common_dir()(which always resolves to the mainrepo's .git directory) to derive the repo name and parent, consistent
with what
detect_repo_path()already does.https://claude.ai/code/session_01A59eHjgbg2LRBLysFD3Cmp