GRUD_DEV-1201/parallel thumbnail creation

[smnhgn]

No description provided.

[smnhgn]

Die maxExecuteTime vom worker pool habe ich vorerst auf 2 Minuten (wie im Vertx Beispiel) gelassen.
Habt ihr da Vorschläge was wir da als sinnvollen Wert setzen sollen?

[github-actions]

Test Results

1 119 tests  ±0   1 111 ✅ ±0   2m 54s ⏱️ -31s
  133 suites ±0       8 💤 ±0 
  133 files   ±0       0 ❌ ±0 

Results for commit efca62b. ± Comparison against base commit c5de8fc.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	87%	✅
com/campudus/tableaux/exceptions.scala	0%	❌
com/campudus/tableaux/exceptions.scala	0%	❌
com/campudus/tableaux/arguments.scala	97%	✅
com/campudus/tableaux/Starter.scala	76%	❌
com/campudus/tableaux/controller/SystemController.scala	99%	✅
com/campudus/tableaux/controller/TableauxController.scala	98%	✅
com/campudus/tableaux/controller/UserController.scala	72%	❌
com/campudus/tableaux/controller/StructureController.scala	92%	✅
com/campudus/tableaux/controller/MediaController.scala	79%	❌
com/campudus/tableaux/database/historyType.scala	7%	❌
com/campudus/tableaux/database/languageType.scala	86%	✅
com/campudus/tableaux/database/historyType.scala	66%	❌
com/campudus/tableaux/database/database.scala	96%	✅
com/campudus/tableaux/database/database.scala	81%	✅
com/campudus/tableaux/database/database.scala	97%	✅
com/campudus/tableaux/database/domain/column.scala	71%	❌
com/campudus/tableaux/database/domain/column.scala	64%	❌
com/campudus/tableaux/database/domain/column.scala	95%	✅
com/campudus/tableaux/database/domain/table.scala	96%	✅
com/campudus/tableaux/database/domain/service.scala	81%	✅
com/campudus/tableaux/database/domain/userSetting.scala	60%	❌
com/campudus/tableaux/database/domain/column.scala	77%	❌
com/campudus/tableaux/database/domain/annotation.scala	14%	❌
com/campudus/tableaux/database/domain/column.scala	48%	❌
com/campudus/tableaux/database/domain/annotation.scala	60%	❌
com/campudus/tableaux/database/domain/history.scala	84%	✅
com/campudus/tableaux/database/domain/column.scala	0%	❌
com/campudus/tableaux/database/domain/annotation.scala	83%	✅
com/campudus/tableaux/database/domain/userSetting.scala	95%	✅
com/campudus/tableaux/database/domain/annotation.scala	80%	✅
com/campudus/tableaux/database/domain/userSetting.scala	94%	✅
com/campudus/tableaux/database/domain/table.scala	99%	✅
com/campudus/tableaux/database/domain/column.scala	95%	✅
com/campudus/tableaux/database/domain/file.scala	72%	❌
com/campudus/tableaux/database/domain/userSetting.scala	90%	✅
com/campudus/tableaux/database/domain/userSetting.scala	0%	❌
com/campudus/tableaux/database/domain/domainobject.scala	99%	✅
com/campudus/tableaux/database/domain/column.scala	92%	✅
com/campudus/tableaux/database/domain/column.scala	78%	❌
com/campudus/tableaux/database/domain/domainobject.scala	93%	✅
com/campudus/tableaux/database/domain/column.scala	89%	✅
com/campudus/tableaux/database/model/HistoryModel.scala	98%	✅
com/campudus/tableaux/database/model/FolderModel.scala	95%	✅
com/campudus/tableaux/database/model/UserModel.scala	99%	✅
com/campudus/tableaux/database/model/AttachmentModel.scala	82%	✅
com/campudus/tableaux/database/model/TableauxModel.scala	92%	✅
com/campudus/tableaux/database/model/StructureModel.scala	95%	✅
com/campudus/tableaux/database/model/SystemModel.scala	85%	✅
com/campudus/tableaux/database/model/FileModel.scala	94%	✅
com/campudus/tableaux/database/model/structure/ColumnModel.scala	88%	✅
com/campudus/tableaux/database/model/structure/ColumnModel.scala	88%	✅
com/campudus/tableaux/database/model/structure/TableGroupModel.scala	79%	❌
com/campudus/tableaux/database/model/structure/TableModel.scala	84%	✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala	88%	✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala	93%	✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala	93%	✅
com/campudus/tableaux/helper/FileUtils.scala	74%	❌
com/campudus/tableaux/helper/JsonUtils.scala	95%	✅
com/campudus/tableaux/helper/ResultChecker.scala	98%	✅
com/campudus/tableaux/helper/IdentifierFlattener.scala	83%	✅
com/campudus/tableaux/router/DocumentationRouter.scala	21%	❌
com/campudus/tableaux/router/BaseRouter.scala	64%	❌
com/campudus/tableaux/router/SystemRouter.scala	90%	✅
com/campudus/tableaux/router/MediaRouter.scala	78%	❌
com/campudus/tableaux/router/TableauxRouter.scala	76%	❌
com/campudus/tableaux/router/StructureRouter.scala	99%	✅
com/campudus/tableaux/router/RouterRegistry.scala	53%	❌
com/campudus/tableaux/router/auth/KeycloakAuthHandler.scala	72%	❌
com/campudus/tableaux/router/auth/permission/Condition.scala	89%	✅
com/campudus/tableaux/router/auth/permission/Condition.scala	74%	❌
com/campudus/tableaux/router/auth/permission/Condition.scala	87%	✅
com/campudus/tableaux/router/auth/permission/RoleModel.scala	87%	✅
com/campudus/tableaux/router/auth/permission/RoleModel.scala	0%	❌
com/campudus/tableaux/router/auth/permission/Condition.scala	90%	✅
com/campudus/tableaux/router/auth/permission/Condition.scala	79%	❌
com/campudus/tableaux/router/auth/permission/Action.scala	97%	✅
com/campudus/tableaux/router/auth/permission/Condition.scala	85%	✅
com/campudus/tableaux/router/auth/permission/TableauxUser.scala	63%	❌
com/campudus/tableaux/verticles/ThumbnailVerticle.scala	52%	❌
com/campudus/tableaux/verticles/EventClient.scala	72%	❌
com/campudus/tableaux/verticles/CacheVerticle.scala	76%	❌
com/campudus/tableaux/verticles/JsonSchemaValidator.scala	86%	✅
com/campudus/tableaux/verticles/MessagingVerticle.scala	83%	✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against efca62b

[McHunkyTrunk]

Ich würde auch 2 CPUs mit einschließen, dass hier nur eine blockiert ist.

[smnhgn]

Bei 2 CPUs ist die poolSize 1.
(cpuCount * 3) / 4 -> 1.5 -> 1 (da poolSize Int ist wird das .5 abgeschnitten)

[McHunkyTrunk]

Ich probiere es mal aufm Live-Server aus

[smnhgn]

Hatte falschen Task im Branchnamen, deswegen neuer PR -> GRUD-DEV-1203/parallel thumbnail creation

[zingmane]

Die maxExecuteTime vom worker pool habe ich vorerst auf 2 Minuten (wie im Vertx Beispiel) gelassen. Habt ihr da Vorschläge was wir da als sinnvollen Wert setzen sollen?

Ich würde hier eher die Zeit die wir vorher hatten und zu wenig war erhöhen. Der timeout ist ja pro Task. Also von den 2000ms auf z.b. 10_000ms gehen. Wenn das dann mal wirklcih länger dauert, finde ich es auch sinnvoll, dass ein waring im log steht. Mehrere logs dazu erwarte ich dazu eh nur im warump, im normalen Betrieb sollte das dann eigentlich nicht mehr vorkommen.